Emit 'unsubsribe' event when client has clean=true on disconnect #145 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Nov 15, 2017
lib/handlers/unsubscribe.js
Outdated
| @@ -68,7 +68,7 @@ function completeUnsubscribe (err) { | |||
| return client.emit('error', err) | |||
| } | |||
|
|
|||
| if (!packet.close && packet.unsubscriptions.length > 0) { | |||
| if (client.clean === true && packet.unsubscriptions.length > 0) { | |||
There was a problem hiding this comment.
the check for packet.close must stay. See https://github.com/mcollina/aedes/blob/275bda32461ea8053c8610b8a3e5b6f0f838f1b6/lib/client.js#L214.
Basically if packet.close === true && client.clean === false we should not emit.
There was a problem hiding this comment.
@mcollina , thank you for a clarification, please see the new commit
mcollina
reviewed
Nov 16, 2017
| @@ -123,7 +123,7 @@ test('emit unsubscribe event', function (t) { | |||
| t.plan(6) | |||
|
|
|||
| var broker = aedes() | |||
| var s = connect(setup(broker), { clientId: 'abcde' }) | |||
| var s = connect(setup(broker), { clean: true, clientId: 'abcde' }) | |||
There was a problem hiding this comment.
can you add another test that fails if the event is emitted when clean is false and the connection ends abruptly?
There was a problem hiding this comment.
forget about it, it's already added.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mcollina , i've implemented #145, please review if it's ok to merge.